How to put if statement inside button's OnClickListener in Android

Course Queries Syllabus Queries 2 years ago

0 2 0 0 0 tuteeHUB earn credit +10 pts

5 Star Rating 1 Rating

Posted on 16 Aug 2022, this text provides information on Syllabus Queries related to Course Queries. Please note that while accuracy is prioritized, the data presented might not be entirely correct or up-to-date. This information is offered for general knowledge and informational purposes only, and should not be considered as a substitute for professional advice.

Take Quiz To Earn Credits!

Turn Your Knowledge into Earnings.

tuteehub_quiz

Answers (2)

Post Answer
profilepic.png
manpreet Tuteehub forum best answer Best Answer 2 years ago


I am working on my major project and I want my button to open different intents based on the string array value obtained. I used if and else if statements inside the OnClickListener of the button but it won't click anymore. Please help me.

This is my XML file:

<android.support.v7.widget.CardView
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:layout_margin="5dp"
    app:cardCornerRadius="3dp"
    app:cardElevation="2dp">

<LinearLayout
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical"
    android:padding="@dimen/spacing_large">
    <TextView
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:paddingBottom="@dimen/spacing_middle"
        android:text="Syllabus"
        android:textAppearance="@style/TextAppearance.AppCompat.Title" />

    <Button
        android:id="@+id/buttonpdf"
        style="@style/Widget.AppCompat.Button"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:background="@color/colorPrimary"
        android:text="Open Book" />

LinearLayout> 

And this is the Java file for the same activity:

public class ActivityBookDetails extends AppCompatActivity {

    public static final String EXTRA_OBJCT = "com.app.sample.recipe.OBJ";

    private Book book;
    private FloatingActionButton fab;
    private View parent_view;

    Button button;
    String[] obj;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(activity_book_details);
        parent_view = findViewById(android.R.id.content);
        button = (Button)findViewById(R.id.buttonpdf);


        book = (Book) getIntent().getSerializableExtra(EXTRA_OBJCT);
        fab = (FloatingActionButton) findViewById(R.id.fab);
        fabToggle();
                                                
                                                
0 views
0 shares
profilepic.png
manpreet 2 years ago

You probably shouldn't try to add conditionals inside the OnClickListener, instead the simplest thing to do would be to move your conditional logic to another method for example.

@Override
public void onClick(View view){
    goToNextView();
}

private void goToNextView(){
    if (title_subjects[0] == "Soft Computing") {
        Intent intent = new Intent(ActivityBookDetails.this, pdfviewactivity.class);
        startActivity(intent);
    }
    // else if {}
    // else {}
}

As cricket_007 already suggested there are nicer ways than using if/else if statements. If you plan to add a lot more options maybe consider using an enum or map.

public enum Subjects {
    SOFT_COMPUTING("Soft Computing", pdfviewactivity.class),
    WEB_ENGINEERING("Web Engineering", pdfweben.class),
    NETWORK_MANAGEMENT("Wireless Network", pdfnetwork.class),
    WIRELESS_NETWORK("Network Management", pdfwireless.class);

    private String name;
    private Class clazz;

    Subjects(String name, Class clazz){
        this.name = name;
        this.clazz = clazz;
    }

    public static Class getClass(String title_subject) {
        for(Subjects subject: Subjects.values()) {
            if (subject.name.equals(title_subject)) {
                return subject.clazz;
            }
        }
        return null;
    }
}

private void goToNextView() {

    //Alternative to conditionals using Enum
    Class theClassToGoTo = Subjects.getClass(title_subjects[0]);
    Intent intent = new Intent(ActivityBookDetails.this, theClassToGoTo);
    startActivity(intent);

   //Alternative to conditionals using HashMap
    Map<String, Class> subject_map = new HashMap<>();
    subject_map.put("Soft Computing", pdfviewactivity.class);
    subject_map.put("Web Engineering", pdfweben.class);
    subject_map.put("Wireless Network"
                                                    
                                                    
0 views   0 shares

No matter what stage you're at in your education or career, TuteeHub will help you reach the next level that you're aiming for. Simply,Choose a subject/topic and get started in self-paced practice sessions to improve your knowledge and scores.