warning: control may reach end of non-void function? when returning class

manpreet Best Answer 2 years ago

i have this function that will search an ID that match the borrowed ID in a vector and then will return the borrower with the matching ID. However i keep getting this warning?

Borrower getborrowerbyID(string ID)  
{
    for(int i =0; i<Borrowlist.size();i++)
    {
        if(Borrowlist[i].getID()==ID)
        {
            return Borrowlist[i];

        }
    }
}

manpreet 2 years ago

I would return sucess status instead and pass a match via function argument like this:

bool getborrowerbyID(string ID, Borrower& refBorrower)  
{
    for(int i =0; i<Borrowlist.size();i++)
    {
        if(Borrowlist[i].getID()==ID)
        {
            refBorrower = Borrowlist[i];
            return true; // signall sucess match found
        }
    }
    return false; // signal falure, ie. no match
}

Now you can test if there was a match in same time:

if(getborrowerbyID(ID, refBorrower))
{
      // ok
}
else
{
      // handle error
}