While loop with multiple OR conditions not exiting loop

manpreet Best Answer 2 years ago

I am trying to run a while loop that runs when the input given is not equal to either "1" "2" or "3".

Below you can see the code:

string get_menu_choice()
{
    string option;
    cout << "What action would you like to perform?" << endl;
    cout << "1. View a room."       << endl
         << "2. Create a new room." << endl
         << "3. Delete a room."     << endl;

    cout << "Enter your choice: ";
    cin >> option;

    while (option != "1" || option != "2" || option != "3")
    {
        cout << "Invalid input, enter in only 1, 2 or 3!" << endl;
        cout << "Enter your choice: ";
        cin  >> option;
    }

    return option;
};

When I run this, it doesn't accept 1, 2 or 3 as an acceptable answer and keeps looping through

I have tried changing the statement to while(options != ("1" || "2" || "3")){//code here}however this also was unsuccessful for me.

manpreet 2 years ago

you should code like below:

while(option != "1" && option != "2" && option != "3")