Cleaner way to move renamed files when walking over directory

manpreet Best Answer 2 years ago

I created a script to walk over my directory and move my music files to my music folder while renaming the files using the regular expression library to check if the files are numbered (as I find this to be an annoyance). The script seems to be working fine, as I haven't encountered any errors, but was wondering if there was a cleaner way to do this as this seems a bit convoluted and unpythonic. (Striving to write cleaner code). By cleaner I'm not asking anyone to rewrite my entire code block(s), but rather the check_names function and it's implementation when moving files. If there are other errors those would be helpful to be pointed out for the below reason.

If this is terrible code I apologize for any python "sins" I may have committed as I have only used the os and regular expression modules a few times before.

Since i am learning how to use these and have little exposure at this point, an explanation of why would go a long way to aid in my understanding. All the os.path.join(....) was my attempt at making it cross-platform and not having to hardcode paths. The reason I say this seems a bit convuluted is due to the runtime it takes approximately 1-2 min to do the following on say 6-7 folders: Extract the compressed .zip archives into my original directory walk over these, rename the files if needed, and then finally moved them and then go back to the original directory and delete the remnants of the move, or is this a normal runtime for everything that's going on? (The archives are ~100-300 mb)

The relevant functions are.

def check_names(dirpath, file_name):
    check = False
    new_name = None
    first_check = re.compile("^\d\d - ").match(file_name)
    second_check = re.compile("^\d\d ").match(file_name)
    if first_check != None or second_check != None:
       check = True
       if first_check:
          new_name = file_name[first_check.span()[1]:]
          shutil.move(os.path.join(dirpath, file_name),
                      os.path.join(dirpath, new_name))
       else:
          new_name = file_name[second_check.span()[1]:]
          shutil.move(os.path.join(dirpath, file_name),
                      os.path.join(dirpath, new_name))
    return check, new_name

def move_music(source, destination, file_extension, sub_string):
    source_dir = os.path.split(source)[-1]
    for dirpath, dirnames, filenames in os.walk(source):
        for a_file in filenames:
            if (a_file.endswith(file_extension) and sub_string in a_file):
                check = check_names(dirpath, a_file)
                dir_name = os.path.split(dirpath)[-1]
                if dir_name != source_dir:
                    check_folders(destination, dir_name)
                    if os.path.join(source, dir_name
                                                

                                                                                                        REPLY
                                                    
                                                
                                                


                                                    

                                                        
                                                            0
                                                            views 

                                                            0
                                                                likes 
                                                            
                                                            

                                                            0
                                                            shares

                                                            


    

         Facebook
        
         Twitter
        
        
         Linked In 
        
          WhatsApp